-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extend syntax error information #879
Conversation
@Simulant87 Can you include unit tests for the new behavior? |
@stleary Sure, I added tests for the new exception messages. I am not sure, if you like my latest change, explainging the numbers in the syntax error with (zero based) "index" and (1 based) "number in line". I think this makes it easier to find the error when counting for the wrong character in the input string. But it requires a lot of tests to be updated. If you don't like it, I can also revert it again. But I think it makes the error messages easier to read. |
This reverts commit d69d5e2.
What problem does this code solve? Does the code still compile with Java6? Risks Changes to the API? Will this require a new release? Should the documentation be updated? Does it break the unit tests? Was any code refactored in this commit? Review status Starting 3-day comment window. |
The syntax error contains only the index of the not parsable character. It might be helpful to indclude more information like the current character and why it is not allowed at this place.